GUACAMOLE-2258 : OpenID code flow, client secret and PKCE - #1219

Open

adb014 wants to merge 19 commits into

apache:mainfrom

adb014:openid

Commits on Jun 18, 2026

GUACAMOLE-2258: Add code flow authorisation type, with or without a client secret and with or without pkce

David Bateman
authored and
David Bateman
committed
GUACAMOLE-2258: Use SessionManager directly from getLoginURI to store PKCE removing the need for local REST redirect and callback function

David Bateman
authored and
David Bateman
committed
GUACAMOLE-2258: Reinclude accidentally removed check if implicit token is null

David Bateman
authored and
David Bateman
committed
GUACAMOLE-2258: Minor white-spqce, import changes to minimize impact on existing code

David Bateman
authored and
David Bateman
committed
GUACAMOLE-2258: Remove accidentally committed files

David Bateman
authored and
David Bateman
committed
GUACAMOLE-2258: Add treatment of well-known endpoints

David Bateman
authored and
David Bateman
committed
GUACAMOLE-2258: Treat review comments

David Bateman
authored and
David Bateman
committed
GUACAMOLE-2258: Remove some no longer used imports for TokenValidationService

David Bateman
authored and
David Bateman
committed
GUACAMOLE-2258: Print detected OIDC well-known information at debug-level equals info

David Bateman
authored and
David Bateman
committed
GUACAMOLE-2258: Replace use of java.net.HttpURLConnection with java.net.http.HttpClient, make the outboud url connection asynchronous

David Bateman
authored and
David Bateman
committed
GUACAMOLE-2258: No body in JsonUrlReader for GET method

David Bateman
authored and
David Bateman
committed
GUACAMOLE-2258: Replace openid-auth-timeout with openid-max-pkce-verifier-validity for consistency with openid-max-nonce-validity. Clarification in the comments.

David Bateman
authored and
David Bateman
committed
GUACAMOLE-2258: Copy/Paste editing error in comment block

David Bateman
authored and
David Bateman
committed
GUACAMOLE-2258: Cut/paste/edit mistake in function JsDoc block

David Bateman
authored and
David Bateman
committed
GUACAMOLE-2258: Correct typos and error in all comments of the PR

David Bateman
authored and
David Bateman
committed
GUACAMOLE-2258: Address most of the review comments

David Bateman
authored and
David Bateman
committed
GUACAMOLE-2258: Don't catch all exceptions in exchangeCode function

David Bateman
authored and
David Bateman
committed
GUACAMOLE-2258: Forgot the import needed for the previous change

David Bateman
authored and
David Bateman
committed

Commits on Jun 24, 2026

GUACAMOLE-2258: Also use nonce with code flow
David Bateman
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GUACAMOLE-2258 : OpenID code flow, client secret and PKCE - #1219

GUACAMOLE-2258 : OpenID code flow, client secret and PKCE#1219
adb014 wants to merge 19 commits into
apache:mainfrom
adb014:openid

Commits on Jun 18, 2026

GUACAMOLE-2258: Add code flow authorisation type, with or without a client secret and with or without pkce

GUACAMOLE-2258: Use SessionManager directly from getLoginURI to store PKCE removing the need for local REST redirect and callback function

GUACAMOLE-2258: Reinclude accidentally removed check if implicit token is null

GUACAMOLE-2258: Minor white-spqce, import changes to minimize impact on existing code

GUACAMOLE-2258: Remove accidentally committed files

GUACAMOLE-2258: Add treatment of well-known endpoints

GUACAMOLE-2258: Treat review comments

GUACAMOLE-2258: Remove some no longer used imports for TokenValidationService

GUACAMOLE-2258: Print detected OIDC well-known information at debug-level equals info

GUACAMOLE-2258: Replace use of java.net.HttpURLConnection with java.net.http.HttpClient, make the outboud url connection asynchronous

GUACAMOLE-2258: No body in JsonUrlReader for GET method

GUACAMOLE-2258: Replace openid-auth-timeout with openid-max-pkce-verifier-validity for consistency with openid-max-nonce-validity. Clarification in the comments.

GUACAMOLE-2258: Copy/Paste editing error in comment block

GUACAMOLE-2258: Cut/paste/edit mistake in function JsDoc block

GUACAMOLE-2258: Correct typos and error in all comments of the PR

GUACAMOLE-2258: Address most of the review comments

GUACAMOLE-2258: Don't catch all exceptions in exchangeCode function

GUACAMOLE-2258: Forgot the import needed for the previous change

Commits on Jun 24, 2026

GUACAMOLE-2258: Also use nonce with code flow