Skip to content

Bump org.asynchttpclient:async-http-client from 2.12.4 to 3.0.9 and refactor DownloadZookeeperInitializer in /dubbo-test/dubbo-test-check#16213

Closed
zrlw wants to merge 1 commit intoapache:3.3from
zrlw:3.3-bump-async-http-client
Closed

Bump org.asynchttpclient:async-http-client from 2.12.4 to 3.0.9 and refactor DownloadZookeeperInitializer in /dubbo-test/dubbo-test-check#16213
zrlw wants to merge 1 commit intoapache:3.3from
zrlw:3.3-bump-async-http-client

Conversation

@zrlw
Copy link
Copy Markdown
Contributor

@zrlw zrlw commented Apr 14, 2026

What is the purpose of the change?

DownloadZookeeperInitializer.java needs to be fixed if bump org.asynchttpclient:async-http-client from 2.12.4 to 3.0.9
see details at #16212

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

…efactor DownloadZookeeperInitializer in /dubbo-test/dubbo-test-check
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.34%. Comparing base (d95086c) to head (5bd75fb).

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #16213      +/-   ##
============================================
- Coverage     60.79%   60.34%   -0.46%     
+ Complexity    11751    10238    -1513     
============================================
  Files          1953     1953              
  Lines         89119    89103      -16     
  Branches      13444    13360      -84     
============================================
- Hits          54179    53767     -412     
- Misses        29369    29690     +321     
- Partials       5571     5646      +75     
Flag Coverage Δ
integration-tests-java21 ?
integration-tests-java8 ?
samples-tests-java21 32.17% <ø> (+0.05%) ⬆️
samples-tests-java8 29.85% <ø> (-0.01%) ⬇️
unit-tests-java11 59.01% <ø> (-0.02%) ⬇️
unit-tests-java17 58.50% <ø> (-0.04%) ⬇️
unit-tests-java21 58.50% <ø> (-0.02%) ⬇️
unit-tests-java25 58.47% <ø> (-0.01%) ⬇️
unit-tests-java8 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw
Copy link
Copy Markdown
Contributor Author

zrlw commented Apr 15, 2026

async-http-client 3.0.9 should be used with jdk11+, but current dubbo still needs to support jdk8

@zrlw zrlw closed this Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants