Bump org.asynchttpclient:async-http-client from 2.12.4 to 3.0.9 and refactor DownloadZookeeperInitializer in /dubbo-test/dubbo-test-check#16213
Closed
zrlw wants to merge 1 commit intoapache:3.3from
Closed
Conversation
…efactor DownloadZookeeperInitializer in /dubbo-test/dubbo-test-check
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16213 +/- ##
============================================
- Coverage 60.79% 60.34% -0.46%
+ Complexity 11751 10238 -1513
============================================
Files 1953 1953
Lines 89119 89103 -16
Branches 13444 13360 -84
============================================
- Hits 54179 53767 -412
- Misses 29369 29690 +321
- Partials 5571 5646 +75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
async-http-client 3.0.9 should be used with jdk11+, but current dubbo still needs to support jdk8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
DownloadZookeeperInitializer.javaneeds to be fixed if bump org.asynchttpclient:async-http-client from 2.12.4 to 3.0.9see details at #16212
Checklist