feat: adding add_months datetime expression#4427
Open
athlcode wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Hey @coderfender, @comphead. Created this for add_months spark expression, please review, thank you |
Contributor
|
Thank you @athlcode , I triggered CI but there seems to be some test failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4150
Rationale for this change
add_monthsalready has a native implementation in thedatafusion-sparkcrate, but wasn't wired into Comet, so queries using it fell back to Spark.What changes are included in this PR?
Wires Spark's
AddMonthsto thedatafusion-sparkSparkAddMonthsUDF using thewire-datafusion-functionskill. Also updates the supported-expression docs.How are these changes tested?
Added a SQL file test (
datetime/add_months.sql).