Repository navigation
License: cover contrib/pgcrypto/crypt-md5.c - #2161
Merged
Merged
Conversation
crypt-md5.c is inherited from PostgreSQL and says only that it was imported from FreeBSD, written by Poul-Henning Kamp. LICENSE did not mention it. This was found while checking 2.2.0-incubating-rc3. The FreeBSD revision the file names, src/lib/libcrypt/crypt-md5.c 1.5, carried Kamp's beer-ware notice, which asks that the notice be retained. Reproduce that notice in licenses/LICENSE-beerware-crypt-md5.txt and list the file under it. FreeBSD's copy was later re-released under the 2-clause BSD license (FreeBSD commit d8e82636a47b), and LICENSE mentions that too. Exclude the new licence file from RAT like the other verbatim licence texts. Assisted-by: Claude Code
Member
Author
|
Main: #2160 |
leborchuk
approved these changes
Oct 21, 2026
leborchuk
left a comment
leborchuk
left a comment
Contributor
There was a problem hiding this comment.
LGTM, I wish we had the chance to comply with the Beer-ware license.
MisterRaindrop
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypt-md5.c is inherited from PostgreSQL and says only that it was imported from FreeBSD, written by Poul-Henning Kamp. LICENSE did not mention it. This was found while checking 2.2.0-incubating-rc3.
The FreeBSD revision the file names, src/lib/libcrypt/crypt-md5.c 1.5, carried Kamp's beer-ware notice, which asks that the notice be retained. Reproduce that notice in licenses/LICENSE-beerware-crypt-md5.txt and list the file under it. FreeBSD's copy was later re-released under the 2-clause BSD license (FreeBSD commit d8e82636a47b), and LICENSE mentions that too.
Exclude the new licence file from RAT like the other verbatim licence texts.
Assisted-by: Claude Code
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions