Install Cloud Spanner emulator component in Go PreCommit CI - #39850
Merged
Conversation
The Go Spanner IO integration tests are moving from a Docker testcontainer to a real Spanner emulator driven via `gcloud emulators spanner start`, so this workflow's runner now needs that emulator available. gcloud does not ship the "cloud-spanner-emulator" component by default: it's listed as "Not Installed" in the component manifest even on a freshly-installed CLI matching this runner's install method (tarball + install.sh on linux/amd64), so it must be installed explicitly before the Go tests run.
3 tasks
Contributor
|
Assigning reviewers: R: @liferoad for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
liferoad
approved these changes
Aug 22, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a step to
beam_PreCommit_Go.ymlthat installs thecloud-spanner-emulatorgcloud component before running the Go PreCommit tests. We've previously been unable to run the emulator in docker, however gcloud is available - this installs the spanner emulator so that we can use it for improving tests.This is split out from a larger in-progress PR (#37991) that replaces the Docker-testcontainer-based Spanner emulator setup in the Go Spanner IO integration tests with a real emulator driven via
gcloud emulators spanner start. That workflow is triggered viapull_request_target, which always runs the workflow file frommasterrather than the PR branch, so this CI change needs to land onmasteron its own before #37991's checks can pick it up.CHANGES.mdwith noteworthy changes.