-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[Java] Bound the Watch deduplication state with a timestamp cursor #39746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5c603c7
[Java] Bound the Watch deduplication state with a timestamp cursor
Eliaaazzz 7e9fced
Address review on the Watch timestamp cursor
Eliaaazzz f2f1173
Advance the watermark to the retention floor on empty rounds
Eliaaazzz 3504ac7
Merge remote-tracking branch 'upstream/master' into java-watch-timest…
Eliaaazzz faf2708
Cover Java and Python in the Watch timestamp-cursor CHANGES entry
Eliaaazzz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This statement applies to both Java and Python.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in faf2708. The entry now reads (Java/Python) and names both surfaces:
Watch.growthOf(...).withTimestampCursor()in Java, andallowed_latenessin Python, which #39461 added for the existingtimestamp_cursoroption after the 2.76 branch cut. I also merged master in 3504ac7 to clear the CHANGES.md conflict.