Skip to content

Avoid RequestResponseIO throttler access when throttler is absent #39112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 6 commits into from
Jul 6, 2026
Merged

Avoid RequestResponseIO throttler access when throttler is absent #39112

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6a76fdf
Avoid throttler access when RequestResponseIO has no throttler
fallintoplace Jun 25, 2026
9d23105
Use explicit None checks for throttler in RequestResponseIO
fallintoplace Jun 25, 2026
78329f7
sync PR head for explicit None checks
fallintoplace Jun 25, 2026
6be42f5
Tighten CI-flaky tests around async teardown and minibatch size
fallintoplace Jun 25, 2026
6c7ee9f
Fix formatter regression in pytorch batch size assertion
fallintoplace Jun 25, 2026
8458d9a
Keep RequestResponseIO PR focused
fallintoplace Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdks/python/apache_beam/io/requestresponse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,8 @@ def process(self, request: RequestT, *args, **kwargs):
response = self._repeater.repeat(
self._caller, request, self._timeout, self._metrics_collector)
self._metrics_collector.responses.inc(1)
self._throttler.throttler.successful_request(req_time * MSEC_TO_SEC)
if self._throttler:

@gemini-code-assist gemini-code-assist Bot Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to PEP 8, comparisons to singletons like None should always be done with is or is not, never the equality operators or implicit boolean evaluation when checking if an optional argument/attribute is set. Using is not None is safer and more explicit.

Suggested change
if self._throttler:
if self._throttler is not None:
References
  1. PEP 8: Use 'is not None' when testing whether a variable or argument that defaults to None was set to some other value. (link)

self._throttler.throttler.successful_request(req_time * MSEC_TO_SEC)
yield response
except Exception as e:
raise e
Expand Down
Loading