Skip to content

WriteToJson - force num_shards #38484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunping merged 4 commits into from
May 20, 2026
+15 −5
Merged

WriteToJson - force num_shards #38484

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a82752
force number of shards
derrickaw May 13, 2026
e66c636
update logic based on gemini
derrickaw May 13, 2026
3facdda
address another gemini comment
derrickaw May 13, 2026
8b2d2bd
address one more round
derrickaw May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions sdks/python/apache_beam/dataframe/io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,17 +680,26 @@ def __init__(
self.binary = binary

def expand(self, pcoll):
if 'file_naming' in self.kwargs:
kwargs = dict(self.kwargs)
if 'file_naming' in kwargs:
dir, name = self.path, ''
else:
dir, name = io.filesystems.FileSystems.split(self.path)
num_shards = kwargs.pop('num_shards', None)
max_writers_per_bundle = kwargs.pop('max_writers_per_bundle', None)
write_to_files_kwargs = {}
if num_shards is not None:
write_to_files_kwargs['shards'] = num_shards
write_to_files_kwargs['max_writers_per_bundle'] = (
max_writers_per_bundle if max_writers_per_bundle is not None else 0)
Comment thread
derrickaw marked this conversation as resolved.
Outdated
elif max_writers_per_bundle is not None:
write_to_files_kwargs['max_writers_per_bundle'] = max_writers_per_bundle
return pcoll | fileio.WriteToFiles(
path=dir,
shards=self.kwargs.pop('num_shards', None),
file_naming=self.kwargs.pop(
'file_naming', fileio.default_file_naming(name)),
file_naming=kwargs.pop('file_naming', fileio.default_file_naming(name)),
sink=lambda _: _WriteToPandasFileSink(
self.writer, self.args, self.kwargs, self.incremental, self.binary))
self.writer, self.args, kwargs, self.incremental, self.binary),
Comment thread
derrickaw marked this conversation as resolved.
**write_to_files_kwargs)


class _WriteToPandasFileSink(fileio.FileSink):
Expand Down
Loading