Skip to content

GH-46691: [CI][Packaging] Update platform tag on generated wheel name to match newest auditwheel naming #46705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 6 commits into from
Jun 5, 2025
Merged

GH-46691: [CI][Packaging] Update platform tag on generated wheel name to match newest auditwheel naming #46705

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bf382f7
GH-46691: [CI][Packaging] Reorder platform tag to match wheel name ge…
raulcd Jun 4, 2025
afdf276
Use regex to match other cases
raulcd Jun 4, 2025
5e50734
Try something
raulcd Jun 4, 2025
0f8d840
Fix typo
raulcd Jun 4, 2025
4caab32
Fix verification script for validating wheels
raulcd Jun 4, 2025
cc7facb
Try force upgrading to validate if platform tags order is maintained …
raulcd Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dev/release/verify-release-candidate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,8 @@ test_linux_wheels() {
if ! VENV_ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_virtualenv; then
continue
fi
pip install pyarrow-${TEST_PYARROW_VERSION:-${VERSION}}-cp${pyver/.}-cp${python/.}-${platform}.whl
find . -name pyarrow-${TEST_PYARROW_VERSION:-${VERSION}}-cp${pyver/.}-cp${python/.}-*.whl | grep -E "${platform}" | \
Copy link
Copy Markdown
Member

@kou kou Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
find . -name pyarrow-${TEST_PYARROW_VERSION:-${VERSION}}-cp${pyver/.}-cp${python/.}-*.whl | grep -E "${platform}" | \
ls pyarrow-${TEST_PYARROW_VERSION:-${VERSION}}-cp${pyver/.}-cp${python/.}-*.whl | grep -E "${platform}" | \

xargs pip install
ARROW_GCS=${check_gcs} \
ARROW_VERSION=${VERSION} \
CHECK_VERSION=${check_version} \
Expand Down
6 changes: 3 additions & 3 deletions dev/tasks/python-wheels/github.linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
-e TEST_DEFAULT=0 \
-e TEST_PYARROW_VERSION={{ arrow.no_rc_version }} \
-e TEST_PYTHON_VERSIONS={{ python_version }} \
-e TEST_WHEEL_PLATFORM_TAGS={{ wheel_platform_tag }} \
-e TEST_WHEEL_PLATFORM_TAGS="{{ wheel_platform_tag }}" \
-e TEST_WHEELS=1 \
almalinux-verify-rc

Expand All @@ -116,7 +116,7 @@ jobs:
-e TEST_DEFAULT=0 \
-e TEST_PYARROW_VERSION={{ arrow.no_rc_version }} \
-e TEST_PYTHON_VERSIONS={{ python_version }} \
-e TEST_WHEEL_PLATFORM_TAGS={{ wheel_platform_tag }} \
-e TEST_WHEEL_PLATFORM_TAGS="{{ wheel_platform_tag }}" \
-e TEST_WHEELS=1 \
ubuntu-verify-rc

Expand All @@ -131,7 +131,7 @@ jobs:
-e TEST_DEFAULT=0 \
-e TEST_PYARROW_VERSION={{ arrow.no_rc_version }} \
-e TEST_PYTHON_VERSIONS={{ python_version }} \
-e TEST_WHEEL_PLATFORM_TAGS={{ wheel_platform_tag }} \
-e TEST_WHEEL_PLATFORM_TAGS="{{ wheel_platform_tag }}" \
-e TEST_WHEELS=1 \
ubuntu-verify-rc

Expand Down
4 changes: 2 additions & 2 deletions dev/tasks/tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,9 @@ tasks:

{############################## Wheel Linux ##################################}

{% for wheel_kind, arch, version, platform_tag in [("manylinux", "amd64", "2014", "manylinux_2_17_x86_64.manylinux2014_x86_64"),
{% for wheel_kind, arch, version, platform_tag in [("manylinux", "amd64", "2014", "manylinux(2014|_2_17)_x86_64.manylinux(2014|_2_17)_x86_64"),
("manylinux", "amd64", "2-28", "manylinux_2_28_x86_64"),
("manylinux", "arm64", "2014", "manylinux_2_17_aarch64.manylinux2014_aarch64"),
("manylinux", "arm64", "2014", "manylinux(2014|_2_17)_aarch64.manylinux(2014|_2_17)_aarch64"),
("manylinux", "arm64", "2-28", "manylinux_2_28_aarch64"),
("musllinux", "amd64", "1-2", "musllinux_1_2_x86_64"),
("musllinux", "arm64", "1-2", "musllinux_1_2_aarch64")] %}
Expand Down
Loading