Skip to content

AMBARI-26598: Don't execute dangerous metatool command when starting hiveserver2 #4127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eubnara wants to merge 1 commit into
base: trunk
Choose a base branch
from
+0 −25
Open

AMBARI-26598: Don't execute dangerous metatool command when starting hiveserver2 #4127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions ...rver/src/main/resources/stacks/BIGTOP/3.2.0/services/HIVE/package/scripts/hive_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
from resource_management.core.exceptions import ComponentIsNotRunning, Fail
from resource_management.core.logger import Logger
from resource_management.core.resources.system import File, Execute
from resource_management.core.shell import as_user, quote_bash_args
from resource_management.libraries.functions import get_user_call_output
from resource_management.libraries.functions import StackFeature
from resource_management.libraries.functions.check_process_status import (
Expand Down Expand Up @@ -70,9 +69,6 @@ def hive_service(name, action="start", upgrade_type=None):
)

if action == "start":
if name == "hiveserver2":
check_fs_root(params.hive_conf_dir, params.execute_path)

daemon_cmd = cmd
hadoop_home = params.hadoop_home
hive_bin = "hive"
Expand Down Expand Up @@ -189,27 +185,6 @@ def validate_connection(target_path_to_jdbc, hive_lib_path):
raise


def check_fs_root(conf_dir, execution_path):
import params

if not params.fs_root.startswith("hdfs://"):
Logger.info("Skipping fs root check as fs_root does not start with hdfs://")
return

metatool_cmd = format("hive --config {conf_dir} --service metatool")
cmd = as_user(
format("{metatool_cmd} -listFSRoot", env={"PATH": execution_path}), params.hive_user
) + format(
" 2>/dev/null | grep hdfs:// | cut -f1,2,3 -d '/' | grep -v '{fs_root}' | head -1"
)
code, out = shell.call(cmd)

if code == 0 and out.strip() != "" and params.fs_root.strip() != out.strip():
out = out.strip()
cmd = format("{metatool_cmd} -updateLocation {fs_root} {out}")
Execute(cmd, user=params.hive_user, environment={"PATH": execution_path})


@retry(times=30, sleep_time=10, err_class=Fail)
def wait_for_znode():
import params
Expand Down