Skip to content
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion ambari-server/src/main/assemblies/server.xml
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,19 @@
<outputDirectory>/usr/lib/ambari-server</outputDirectory>
<unpack>false</unpack>
<scope>runtime</scope>
<!--
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should exclude them from individual dependencies which pulls them as transitive dependencies. Let's keep assembly clean from any kind of filtering.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback @sandeepk318 I've updated the approach to exclude the legacy JARs from individual dependencies rather than the assembly descriptor, keeping the assembly clean.

Exclude legacy JARs brought transitively by dependencies
(e.g., Hadoop, swagger-jaxrs) that conflict at runtime with the versions
currently used by Ambari (ehcache 3.x, Jersey 2.x, JAX-RS 2.x).-->
<excludes>
<exclude>net.sf.ehcache:ehcache</exclude>
<exclude>com.sun.jersey:jersey-core</exclude>
<exclude>com.sun.jersey:jersey-server</exclude>
<exclude>com.sun.jersey:jersey-json</exclude>
<exclude>com.sun.jersey:jersey-servlet</exclude>
<exclude>com.sun.jersey:jersey-client</exclude>
<exclude>javax.ws.rs:jsr311-api</exclude>
</excludes>
</dependencySet>
</dependencySets>
</assembly>
</assembly>