Skip to content

v2.1: Disables tar's sparse file handling when archiving a snapshot (backport of #5445) #5505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brooksprumo merged 1 commit into from
Mar 27, 2025
Merged

v2.1: Disables tar's sparse file handling when archiving a snapshot (backport of #5445) #5505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions runtime/src/snapshot_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,6 +1036,15 @@ fn archive_snapshot(

let do_archive_files = |encoder: &mut dyn Write| -> std::result::Result<(), E> {
let mut archive = tar::Builder::new(encoder);
// Disable sparse file handling. This seems to be the root cause of an issue when
// upgrading v2.0 to v2.1, and the tar crate from 0.4.41 to 0.4.42.
// Since the tarball will still go through compression (zstd/etc) afterwards, disabling
// sparse handling in the tar itself should be fine.
//
// Likely introduced in [^1]. Tracking resolution in [^2].
// [^1] https://github.com/alexcrichton/tar-rs/pull/375
// [^2] https://github.com/alexcrichton/tar-rs/issues/403
archive.sparse(false);
// Serialize the version and snapshots files before accounts so we can quickly determine the version
// and other bank fields. This is necessary if we want to interleave unpacking with reconstruction
archive
Expand Down