fix: fix pagination cursor handling in beta.skills.list#1403
Closed
xodn348 wants to merge 1 commit intoanthropics:mainfrom
Closed
fix: fix pagination cursor handling in beta.skills.list#1403xodn348 wants to merge 1 commit intoanthropics:mainfrom
xodn348 wants to merge 1 commit intoanthropics:mainfrom
Conversation
022ecc9 to
6a30250
Compare
Collaborator
|
Thank you for the PR - |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1391.
This updates
beta.skills.list()to use the cursor parameters returned by the standard page type:pagetoafter_id/before_idSyncPage/AsyncPageinstead of cursor-page typesI rebased this on current
upstream/mainand kept the patch limited to the Skills list pagination surface.Testing:
Result: 90 passed for Python >=3.9 / Pydantic v2, 90 passed for Python >=3.9 / Pydantic v1, and 90 passed for Python >=3.14 / Pydantic v2.