fix: handle single-element tuple in file upload#1356
Open
lui62233 wants to merge 1 commit intoanthropics:mainfrom
Open
fix: handle single-element tuple in file upload#1356lui62233 wants to merge 1 commit intoanthropics:mainfrom
lui62233 wants to merge 1 commit intoanthropics:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When passing a single-element tuple like
(pathlib.Path("/path/to/file"),)as a file argument toclient.beta.files.upload, the SDK crashes withIndexError: tuple index out of rangebecause_transform_fileunconditionally accessesfile[1]without checking tuple length.Fix
In
_transform_fileand_async_transform_file, add a length check before treating a tuple as a(filename, content)pair. Single-element tuples are now correctly treated as(None, content).Fixes #1318