Fix BetaAsyncAbstractMemoryTool docstring to use async examples#1336
Closed
Christian-Sidak wants to merge 1 commit intoanthropics:mainfrom
Closed
Fix BetaAsyncAbstractMemoryTool docstring to use async examples#1336Christian-Sidak wants to merge 1 commit intoanthropics:mainfrom
Christian-Sidak wants to merge 1 commit intoanthropics:mainfrom
Conversation
The docstring was copy-pasted from the sync BetaAbstractMemoryTool without updating for async usage. This fixes: - Base class: BetaAbstractMemoryTool -> BetaAsyncAbstractMemoryTool - Method definitions: def -> async def - Client: Anthropic() -> AsyncAnthropic() - Wrap usage in async def main() / asyncio.run(main()) Fixes anthropics#1290
Author
|
Friendly bump -- let me know if anything needs changing. |
1 similar comment
Author
|
Friendly bump -- let me know if anything needs changing. |
Author
|
Closing due to inactivity. Happy to reopen if there's interest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
BetaAsyncAbstractMemoryTooldocstring was copy-pasted from the syncBetaAbstractMemoryToolwithout updating for async usage. This fixes three errors in the example code:BetaAbstractMemoryTool->BetaAsyncAbstractMemoryTooldef->async defAnthropic()->AsyncAnthropic(), wrapped inasync def main()/asyncio.run(main())Fixes #1290