fix: workspace flag parsing in nr command#325
Merged
antfu merged 2 commits intoantfu-collective:mainfrom Apr 21, 2026
Merged
Conversation
Fixes antfu-collective#322 The -w/--workspace flag without = was being parsed as boolean true instead of accepting the next argument as the workspace path.
antfu
approved these changes
Apr 21, 2026
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where the
-wor--workspaceflag without=did not work in thenrcommand for npm.Problem
Other commands (ni, nlx, nun, nup, nci, nd) worked correctly with
-w packages/foo, onlynrhad this issue.Root Cause
The workspace flag value was being parsed as boolean
trueinstead of accepting the next argument as the workspace path.Fix
Updated the argument parsing in the nr command to match the behavior of other commands by merging
-w valueinto-w=valueformat before passing to the package manager.Testing
Fixes #322