Repository navigation
Keep position() on the step when a predicate path comes first - #158
Merged
Merged
Conversation
position() and last() record the step being filtered. Compiling @Class or a child path earlier in the same predicate replaced that step, so position() counted the wrong nodes and stayed at 1.
|
coverage: 84.785% (+0.08%) from 84.707% — SashaMIT:fix/position-predicate-step into antchfx:master |
Contributor
Author
|
Thanks for merging it. position() stays on the step when a path comes first in the predicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes antchfx/htmlquery#40.
//div[@class='test' and position()=1]returned every div with that class.//div[position()=1 and @class='test']returned only the first.position()is the position of the node in the step being filtered. Compiling@class, or a child path, earlier in the same predicate replaced that step, soposition()counted the wrong nodes and stayed at 1.TestPositionKeepsStepWhenPredicateHasAPathexpects line 4 forposition()=1and lines 5 and 8 forposition()=2. Without the pin,position()=1returns lines 4, 5, and 8.A caller that asks for the first match and then uses every returned node acts on the rest of the set. This is the wrong node set.