Repository navigation
Default string-length() to the context node - #156
Merged
zhengchun merged 1 commit intoOct 14, 2026
Merged
Conversation
string-length() with no argument failed to compile with "must have at least one parameter". XPath 1.0 section 4.2 makes the argument optional and defaults it to the string-value of the context node, so `//title[string-length() > 10]` should work. Use the same self::node() default as normalize-space(), and reject more than one argument instead. The invalid-expression test now checks the two-argument case.
|
coverage: 84.737% (+0.03%) from 84.707% — LuisFigueroaG:fix/string-length-context-node into antchfx:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
string-length()with no argument fails to compile with "string-length function must have at least one parameter". XPath 1.0 §4.2 makes the argument optional and defaults it to the string-value of the context node, so something like//title[string-length() > 10]should work.This uses the same
self::node()default thatnormalize-space()already uses, and rejects more than one argument instead.TestInvalidXPathhad a case for the no-argument form, so I changed it to the two-argument one, and added context-node cases toTest_func_string_length.