Repository navigation
Convert a number or boolean argument in substring-before and substring-after - #148
Merged
Merged
Conversation
…g-after substringIndFunc only handled string and node-set arguments, so any other value was read as "": substring-before(12345, 3) gave "" instead of "12". Fall back to asString, as antchfx#144 did for the other string functions.
|
coverage: 83.868% (+0.02%) from 83.847% — youdie006:substring-ind-asstring into antchfx:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #144.
substring-beforeandsubstring-aftersharesubstringIndFunc, which also switches oncase stringandcase queryonly, for both arguments, so a number or boolean is read as"":substring-before(12345, 3)12""substring-after(12345, 3)45""substring-after("a1b", 1)b""substring-before(true(), "u")tr""substring-after(1 div 0, "fin")ity""This adds the same
default: asString(t, v)case to both switches. The new rows inTest_func_substring_after/_beforefail on master; dropping either default fails them, andfmt.Sprintinstead ofasStringfails the1 div 0row.go test ./...andgo vet ./...pass.starts-with,ends-withandcontainsstill panic on a number, which the tests from #134 expect, so I left them alone.Written with AI assistance (Claude); I have reviewed the change.