Skip to content

Generalize edge property type implementation #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
greschd wants to merge 8 commits into
base: main
Choose a base branch
from

Create common implementation for edge property types

9d8abd2
Select commit
Loading
Failed to load commit list.
Draft

Generalize edge property type implementation #607

Create common implementation for edge property types
9d8abd2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 5, 2026 in 0s

93.11% (-0.21%) compared to 57ec18e

View this Pull Request on Codecov

93.11% (-0.21%) compared to 57ec18e

Details

Codecov Report

❌ Patch coverage is 88.62559% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.11%. Comparing base (57ec18e) to head (9d8abd2).
⚠️ Report is 224 commits behind head on main.

Files with missing lines Patch % Lines
.../_tree_objects/_grpc_helpers/edge_property_list.py 82.66% 13 Missing ⚠️
...ore/_tree_objects/_grpc_helpers/supported_since.py 86.20% 4 Missing ⚠️
...ore/_tree_objects/_grpc_helpers/property_helper.py 89.65% 3 Missing ⚠️
src/ansys/acp/core/_tree_objects/base.py 81.81% 2 Missing ⚠️
.../_tree_objects/_grpc_helpers/linked_object_list.py 80.00% 1 Missing ⚠️
...nsys/acp/core/_tree_objects/butt_joint_sequence.py 98.03% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   93.31%   93.11%   -0.21%     
==========================================
  Files          84       86       +2     
  Lines        4445     4619     +174     
==========================================
+ Hits         4148     4301     +153     
- Misses        297      318      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov