Change mutagen dependency to git version#192
Merged
Merged
Conversation
anoadragon453
approved these changes
Aug 1, 2023
Owner
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
Good catch. I had forgotten that we were relying unmerged behavior for mutagen. This LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We rely on quodlibet/mutagen#601 to be able to detect song lengths for tagless mp3s. However this is not in a current release of Mutagen. The last release of Mutagen was Oct 2022 and a new release seems stalled quodlibet/mutagen#612.
I updated venv packages at some point and reintroduced this "bug" by accident, so I think it's good that
requirements.txtreflect the real expected requirements. We could additionally choose to pin a specific commit after testing.