Skip to content

docs(docker): remove deprecated version field from docker-compose examples - #174

Closed
andrerfneves wants to merge 1 commit into
mainfrom
maintenance/fix-deprecated-compose-version-20260611
Closed

andrerfneves wants to merge 1 commit into
mainfrom
maintenance/fix-deprecated-compose-version-20260611

Conversation

@andrerfneves

Copy link
Copy Markdown
Owner

Summary

Removes the deprecated version field from docker-compose configuration examples in deployment documentation.

Problem

  • Both docker-compose examples in DEPLOYMENT_DOCKER.md included version: '3.8'
  • The version field is deprecated in Docker Compose v2 (the current standard)
  • Docker Compose v2 ignores the field entirely and warns: WARN[0000] ./docker-compose.yml: \version` is obsolete`
  • PR docs: replace deprecated docker-compose v1 commands with docker compose v2 #170 already updates the docker-compose command invocations to docker compose, but the compose file content still had the deprecated field

Changes

Example Before After
Basic compose (line 28) version: '3.8' + services services only
SSL reverse proxy (line 55) version: '3.8' + services services only

Verification

  • The version field is purely cosmetic in Docker Compose v2+ — removing it causes no behavioral change
  • The docker-compose examples remain valid and functional
  • No other files were modified

…mples

The version field in docker-compose.yml files is deprecated in Docker
Compose v2 and generates warnings when present. The field was only
required by the v1 Python CLI. Docker Compose v2 ignores it entirely.

- Remove version: '3.8' from the basic docker-compose example
- Remove version: '3.8' from the SSL reverse proxy docker-compose example
@vercel

vercel Bot commented Jun 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lightning-decoder Ready Ready Preview, Comment Jun 11, 2026 8:07am

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3e0ffe6287

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread DEPLOYMENT_DOCKER.md
```yaml
version: '3.8'

services:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep compose examples compatible with docker-compose

In environments where users follow the documented docker-compose up -d command in this section with the legacy Python docker-compose binary (<1.27), dropping the top-level version makes this be interpreted as file-format v1; Docker’s history docs describe v1 as the hyphenated docker-compose CLI and note that file format 1 lacks a top-level services key, while optional version is a Compose v2/v5 behavior. This example will fail for those users unless the commands are also changed to docker compose or the version line is retained.

Useful? React with 👍 / 👎.

This branch was successfully deployed

1 active deployment
Preview — 3e0ffe62 Deployed Jun 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant