Skip to content

Port Netflix/Hystrix#1976 remove canceled timer tasks #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amrith92 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Port Netflix/Hystrix#1976 remove canceled timer tasks #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hystrix-core/src/main/java/com/netflix/hystrix/util/HystrixTimer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ public Thread newThread(Runnable r) {
}

executor = new ScheduledThreadPoolExecutor(coreSize, threadFactory);
executor.setRemoveOnCancelPolicy(true);

@chatgpt-codex-connector chatgpt-codex-connector Bot May 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve Java 6 timer compatibility

This call uses ScheduledThreadPoolExecutor.setRemoveOnCancelPolicy, which is only available starting in Java 7, but the project still documents support for “Java 6 or later” in README.md:140. On a Java 6 runtime, initializing HystrixTimer now throws NoSuchMethodError here before initialized is set, leaving the singleton executor non-null but uninitialized; later timer use can then spin in startThreadIfNeeded() instead of recovering. Please either avoid this API on Java 6 (for example by reflective/version-gated use) or explicitly drop Java 6 support.

Useful? React with 👍 / 👎.

initialized = true;
}

Expand Down