Restore commit-msg hook in the CLI - #2
Open
sensei-woo wants to merge 1 commit into
Open
Conversation
Resolve the final message before running commit-msg while the workspace transaction is still open. Hook edits are reworded into the same transaction, and failures roll back the commit. Tests cover provided and editor messages, rejection, and --no-hooks.
sensei-woo
marked this pull request as ready for review
August 9, 2026 03:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on gitbutlerapp#15222. Merging this PR into the base branch will add
commit-msgsupport directly to that draft.Summary
commit-msgafter the provided or editor message has been resolved--no-hooksand isolate hook fixtures from contributors' globalcore.hooksPathThis completes the
commit-msgportion of gitbutlerapp#15209, including attribution hooks that edit the commit message.Verification
cargo fmt --all -- --checkcargo test -p but --test but "command::commit::" --no-default-features --features legacy(71 passed)cargo clippy -p but --test but --no-default-features --features legacy -- -D warningsThe single commit is GitHub-signed and shows as Verified.