run a cargo update to update all dependencies in lock file#29
Open
pcone wants to merge 1 commit intoamethyst:masterfrom
Open
run a cargo update to update all dependencies in lock file#29pcone wants to merge 1 commit intoamethyst:masterfrom
pcone wants to merge 1 commit intoamethyst:masterfrom
Conversation
this fixes build issues with lexical-core doing arithmetic operations that are invalid on newer versions of rust
|
This also fixes compilation in Ubuntu. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes build issues with lexical-core doing arithmetic operations that are invalid on newer versions of rust. (#27)
I'm not super familiar with Rust package management - it's possible an even more robust solution would involve somehow specifying a version for the transitive dependency on lexical-core in cargo.toml, but just updating the lock file seems like enough of a fix anyway.
I've tested this on a windows 10 box and the app opens and renders properly, but haven't tested on mac/linux.