Skip to content

Update uncrustify version selection to support >= 0.78.1 #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clalancette merged 2 commits into from
May 7, 2026
Merged

Update uncrustify version selection to support >= 0.78.1 #581

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89c2ec6
Update uncrustify version selection to support >= 0.78.1
mjcarroll May 6, 2026
436daa6
Merge remote-tracking branch 'origin/rolling' into fix/uncrustify-ver…
mjcarroll May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ament_uncrustify/ament_uncrustify/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ def main(argv: list[str] = sys.argv[1:]) -> Literal[0, 1]:
return 1

# Version 0.78.1 is different enough that we have a specific
# configuration file for it. Anything before that uses the 0.72 one.
# configuration file for it. Anything newer than or equal to that
# uses the 0.78 one. Anything before that uses the 0.72 one.
# The strings that uncrustify can print vary depending on how it was
# built; common variations are "Uncrustify_d-0.78.1"
# and "Uncrustify-0.72.0_f".
Expand All @@ -59,7 +60,9 @@ def main(argv: list[str] = sys.argv[1:]) -> Literal[0, 1]:
return 1

version = version_match.group(1)
if version == b'0.78.1':
# Note: we use byte comparison here. This works as long as the
# major and minor versions are the same number of digits.
if version >= b'0.78.1':
default_config_file = 'ament_code_style_0_78.cfg'
else:
default_config_file = 'ament_code_style_0_72.cfg'
Expand Down