Draft
Conversation
Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>
85be031 to
6ff188f
Compare
Member
|
See this relevant issue: #497 |
|
Not trying to advertise, but there is now an ament_ruff package and accompanying cmake hook package (discourse post here). It could be used as a starting point for this PR, or as-is by users via source or pip (cli tool only). The repo I linked could still use:
|
| <author email=""></author> | ||
|
|
||
| <exec_depend>ament_lint</exec_depend> | ||
| <exec_depend>python3-ruff</exec_depend> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:
The code changes are currently preliminary and not yet finalized. I’m not seeking feedback on the implementation at this stage.
ament_ruff
I’m new to ament_lint, so I’m not fully aware of all the implications of adding a new tool. I wanted to use this as a starting point to settle the discussion on whether we should support Ruff. Feel free to get the discussion rolling before I invest much effort into it! :)
There has already been a discussion on this topic on ROS Discourse:
Recommended Way to Format Python Code
This PR aims to adds ament_ruff, a fast and modern Python linting and formatting tool, to ament_lint. Ruff combines the functionality of ament_flake8, ament-pydocstyle, ament_pyflakes, ament_pep257 into a single, high-performance tool, simplifying the toolchain and improving developer productivity.
Key Benefits: