fix(security): 2 improvements across 2 files#574
Open
tomaioo wants to merge 2 commits intoambuda-org:mainfrom
Open
fix(security): 2 improvements across 2 files#574tomaioo wants to merge 2 commits intoambuda-org:mainfrom
tomaioo wants to merge 2 commits intoambuda-org:mainfrom
Conversation
- Security: Unescaped HTML rendered with `|safe` in HTMX partial can enable XSS - Security: Unsafe HTML injection and malformed attribute in text block template Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Unescaped HTML rendered with `|safe` in HTMX partial can enable XSS - Security: Unsafe HTML injection and malformed attribute in text block template Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
High| File:ambuda/templates/htmx/parsed-tokens.html:L1The template renders
aligneddirectly with|safe, which disables Jinja auto-escaping. Ifalignedcan contain user-controlled or externally sourced content (directly or indirectly), attackers can inject arbitrary HTML/JS and execute script in users' browsers.Solution
Avoid
|safefor untrusted content. Sanitize HTML server-side with a strict allowlist (e.g., Bleach) before rendering, or render as escaped text. If rich formatting is required, define a minimal allowed tag/attribute set and strip scripts/event handlers/unsafe URLs.Changes
ambuda/templates/htmx/parsed-tokens.html(modified)ambuda/templates/htmx/text-block.html(modified)