chore: fix frontend action#540
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the frontend Vitest configuration to reflect updated dependency inlining behavior, and updates the frontend TypeScript project configuration to avoid typechecking the Vitest config file.
Changes:
- Move Vitest dependency inlining configuration for
cmdkundertest.server.deps.inline. - Exclude
vitest.config.tsfromfrontend/tsconfig.jsonto prevent it from being included in the TS project.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
frontend/vitest.config.ts |
Updates where cmdk is inlined for Vitest runs by nesting under test.server.deps. |
frontend/tsconfig.json |
Excludes vitest.config.ts from the TS project to avoid TS/Next typecheck involvement. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dspachos
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
Two configuration-only fixes to unblock the frontend CI action. The changes migrate a deprecated Vitest API and resolve a TypeScript compilation conflict introduced by the vitest config file coexisting with the Next.js TS project.
vitest.config.ts: Movesdeps.inline: ["cmdk"]from the deprecatedtest.depslocation totest.server.deps, which is the correct placement in Vitest v1+. Behavior is equivalent.tsconfig.json: Addsvitest.config.tsto theexcludelist so the Next.js TypeScript plugin (which usesmoduleResolution: "bundler") no longer tries to type-check the vitest config, which imports fromvitest/configand has incompatible type expectations.Confidence Score: 5/5
Both changes are minimal, targeted config fixes with no runtime or logic impact — safe to merge.
The two changes are isolated to build/test configuration: one migrates a deprecated Vitest option to the current API location, and the other removes a type-checking conflict between the vitest config file and the Next.js TypeScript plugin. Neither change touches application logic, data handling, or runtime behavior.
No files require special attention.
Important Files Changed
deps.inlinefrom the deprecated top-leveltest.depstotest.server.deps, aligning with the Vitest v1+ API.vitest.config.tsfrom the Next.js TypeScript project to prevent type conflicts betweenvitest/configand the Next.js TypeScript plugin.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Frontend CI Action] --> B{TypeScript Check} A --> C{Vitest Tests} B --> D["tsconfig.json\n(include: **/*.ts)"] D -->|Before: included| E["vitest.config.ts\n(imports vitest/config)"] E -->|Type conflict with Next.js plugin| F["❌ tsc error"] D -->|After: excluded| G["vitest.config.ts excluded\nfrom TS project"] G --> H["✅ tsc passes"] C --> I["vitest.config.ts"] I -->|Before: test.deps.inline| J["Deprecated API\n(Vitest v1+)"] J --> K["⚠️ Warning / broken"] I -->|After: test.server.deps.inline| L["Current API\n(Vitest v1+)"] L --> M["✅ cmdk inlined correctly"]Reviews (1): Last reviewed commit: "chore: fix frontend action" | Re-trigger Greptile