Skip to content

chore: fix frontend action#540

Merged
dan2k3k4 merged 1 commit into
devfrom
fix-frontend-action
Jun 2, 2026
Merged

chore: fix frontend action#540
dan2k3k4 merged 1 commit into
devfrom
fix-frontend-action

Conversation

@dan2k3k4
Copy link
Copy Markdown
Member

@dan2k3k4 dan2k3k4 commented Jun 1, 2026

Greptile Summary

Two configuration-only fixes to unblock the frontend CI action. The changes migrate a deprecated Vitest API and resolve a TypeScript compilation conflict introduced by the vitest config file coexisting with the Next.js TS project.

  • vitest.config.ts: Moves deps.inline: ["cmdk"] from the deprecated test.deps location to test.server.deps, which is the correct placement in Vitest v1+. Behavior is equivalent.
  • tsconfig.json: Adds vitest.config.ts to the exclude list so the Next.js TypeScript plugin (which uses moduleResolution: "bundler") no longer tries to type-check the vitest config, which imports from vitest/config and has incompatible type expectations.

Confidence Score: 5/5

Both changes are minimal, targeted config fixes with no runtime or logic impact — safe to merge.

The two changes are isolated to build/test configuration: one migrates a deprecated Vitest option to the current API location, and the other removes a type-checking conflict between the vitest config file and the Next.js TypeScript plugin. Neither change touches application logic, data handling, or runtime behavior.

No files require special attention.

Important Files Changed

Filename Overview
frontend/vitest.config.ts Moves deps.inline from the deprecated top-level test.deps to test.server.deps, aligning with the Vitest v1+ API.
frontend/tsconfig.json Excludes vitest.config.ts from the Next.js TypeScript project to prevent type conflicts between vitest/config and the Next.js TypeScript plugin.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Frontend CI Action] --> B{TypeScript Check}
    A --> C{Vitest Tests}

    B --> D["tsconfig.json\n(include: **/*.ts)"]
    D -->|Before: included| E["vitest.config.ts\n(imports vitest/config)"]
    E -->|Type conflict with Next.js plugin| F["❌ tsc error"]

    D -->|After: excluded| G["vitest.config.ts excluded\nfrom TS project"]
    G --> H["✅ tsc passes"]

    C --> I["vitest.config.ts"]
    I -->|Before: test.deps.inline| J["Deprecated API\n(Vitest v1+)"]
    J --> K["⚠️ Warning / broken"]

    I -->|After: test.server.deps.inline| L["Current API\n(Vitest v1+)"]
    L --> M["✅ cmdk inlined correctly"]
Loading

Reviews (1): Last reviewed commit: "chore: fix frontend action" | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the frontend Vitest configuration to reflect updated dependency inlining behavior, and updates the frontend TypeScript project configuration to avoid typechecking the Vitest config file.

Changes:

  • Move Vitest dependency inlining configuration for cmdk under test.server.deps.inline.
  • Exclude vitest.config.ts from frontend/tsconfig.json to prevent it from being included in the TS project.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
frontend/vitest.config.ts Updates where cmdk is inlined for Vitest runs by nesting under test.server.deps.
frontend/tsconfig.json Excludes vitest.config.ts from the TS project to avoid TS/Next typecheck involvement.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dan2k3k4 dan2k3k4 merged commit 190f0bf into dev Jun 2, 2026
11 checks passed
@dan2k3k4 dan2k3k4 deleted the fix-frontend-action branch June 2, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants