Skip to content

Make username and password optional #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Stanislav Khromov (khromov) wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

Make username and password optional #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions api/node-proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ const server = http.createServer(function(req, res) {

// load from ENVs
const origin = process.env.ORIGIN;
const password = process.env.PASSWORD;
const username = process.env.USERNAME;
const password = process.env.PASSWORD || null;
const username = process.env.USERNAME || null;


const credentialsConfigured = username && password;

// console.log('ORIGIN:', process.env.ORIGIN);

const credentials = auth(req);
if (!credentials || !isAuthed(credentials, username, password)) {
if (credentialsConfigured && (!credentials || !isAuthed(credentials, username, password))) {
res.statusCode = 401;
res.setHeader('WWW-Authenticate', 'Basic realm="example"');
res.end('Access denied.');
Expand Down Expand Up @@ -47,4 +47,4 @@ server.listen(port);

const isAuthed = function (credentials, username, password) {
return credentials.name === username && credentials.pass === password;
}
}