docs(adr-039): kill-switch 診断メッセージ網羅原則 + 新規 feature self-review checklist 追記#189
Merged
Merged
Conversation
…ist 追記 順位 164: § 決定 2 (Kill-switch) に「診断メッセージは実装の受理値を網羅する」 原則を追記。判定関数が複数値を受理するのにメッセージが 1 値固定だと spec-impl drift になる点を、PR #179 の CLI_DOCS_LINT_DISABLE 実例とともに codify。 順位 174: 「新規 experimental feature 追加時の self-review checklist」section を 新設。config schema / feature flag default OFF / docs example / test coverage の 4 点整合を mechanical に確認する手順を、PR #184 CR Major M-2 の OK/NG 実例付きで codify。 両タスクとも docs/claude-code-web-tasks.md / todo-summary.md / todo9.md の 該当エントリを削除 (着手フロー step 3-4)。 https://claude.ai/code/session_01N4EC63wSspZRjuWAsTLbTB
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (3)
📝 WalkthroughWalkthroughPR ChangesADR-039 ドキュメント更新と完了タスク削除
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
docs/claude-code-web-tasks.mdの採用タスクから 順位 164 / 174(いずれも ADR-039 の docs-only 追記、同一ファイル編集のため同 PR 推奨)を実装。複数 task を 1 PR に束ねた理由: 両タスクとも編集対象が
docs/adr/adr-039-experimental-feature-standard-pattern.mdで、タスク表でも「同一 ADR-039 編集」「同 PR 推奨」と明記されているため。変更内容
順位 164 — § 決定 2 (Kill-switch) に診断メッセージ網羅原則を追記 (PR #179 T3-#1)
is_*_value等) が受理する全 value variant を反映する原則を codify1/true/TRUE/True) を受理するのにメッセージが 1 値固定だと spec-impl drift になる点を、PR feat(cli-docs-lint): preamble + cross-ref validator in push-runner quality_gate (ranks 95+96 land) #179 のCLI_DOCS_LINT_DISABLE実例とともに明文化順位 174 — 「新規 experimental feature 追加時の self-review checklist」section 新設 (PR #184 T3-#2)
weekly_review_reminderのenabled = trueが opt-in 違反) を OK/NG 実例として inline cite[session_start.staleness]) は scope 外である旨を補足着手フローに伴う台帳更新 (step 3-4)
docs/claude-code-web-tasks.mdの 164 / 174 行を削除docs/todo-summary.mdの 164 / 174 行を削除docs/todo9.mdの詳細エントリ 2 件を削除検証
.markdownlint-cli2.jsonc有効ルール = MD028 / MD040 / MD058) に抵触する要素 (blockquote 内空行 / 言語なし code fence / 表前後の空行欠落) は追加していないhttps://claude.ai/code/session_01N4EC63wSspZRjuWAsTLbTB
Generated by Claude Code
Summary by CodeRabbit
Documentation