feat(pubsub): add FallbackPubSubConnect for multi-endpoint reconnection#3833
Open
smuu wants to merge 2 commits intoalloy-rs:mainfrom
Open
feat(pubsub): add FallbackPubSubConnect for multi-endpoint reconnection#3833smuu wants to merge 2 commits intoalloy-rs:mainfrom
smuu wants to merge 2 commits intoalloy-rs:mainfrom
Conversation
smuu
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3816
Motivation
A single WS endpoint failure kills PubSub subscriptions with no automatic recovery to a different endpoint. For use cases like block-following nodes that rely on a continuous subscription stream, this means downtime until manual intervention.
Solution
Adds
FallbackPubSubConnect<T: PubSubConnect>— a wrapper that holds multiple connectors and round-robins across them on reconnection.connect()always uses the first connector (primary);try_reconnect()cycles through all connectors via atomic counter.Tested in production: when the primary WS endpoint was killed,
PubSubServicedetected the failure via missed pong, calledtry_reconnect, failed over to the second endpoint, and resumed the block subscription automatically.PR Checklist