fix(provider): reap_timeouts not firing for txs already in waiting_confs#3729
Open
vanityKoa wants to merge 1 commit intoalloy-rs:mainfrom
Open
fix(provider): reap_timeouts not firing for txs already in waiting_confs#3729vanityKoa wants to merge 1 commit intoalloy-rs:mainfrom
vanityKoa wants to merge 1 commit intoalloy-rs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a tx with
with_timeout()gets included in a block but still needs more confirmations, it moves fromunconfirmedtowaiting_confs. Thereap_atentry stays, but when the timeout fires,reap_timeoutsonly checksunconfirmed— the remove returns None and the timeout is silently swallowed.Example:
user sends a tx with
required_confirmations = 20andtimeout = 60s. The tx lands in a block after 5s and moves towaiting_confs. At 60s the timeout fires, butunconfirmed.remove()finds nothing, so the user never gets aTimeouterror and hangs forever if confirmations stall.Now
reap_timeoutsfalls back to scanningwaiting_confswhen the tx isn't inunconfirmed.