TF2: Fix tier1 not compiling with /std:c++20 on msvc#366
Open
EricZhang456 wants to merge 1 commit intoalliedmodders:tf2from
Open
TF2: Fix tier1 not compiling with /std:c++20 on msvc#366EricZhang456 wants to merge 1 commit intoalliedmodders:tf2from
/std:c++20 on msvc#366EricZhang456 wants to merge 1 commit intoalliedmodders:tf2from
Conversation
Member
|
This seems... odd ? I'm not doubting the fix here, but the compiler error seems wrong. I'm going to hold off merging this until I can investigate on my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSVC wouldn't compile
public/tier1/UtlSortVector.hwith C++20Not sure why this is the case, but the fix is simple enough. Might be the same case for other branches as well.