Backport: Convert package.pl to Python.#1135
Open
MisterCalvin wants to merge 1 commit intoalliedmodders:1.9-devfrom
Open
Backport: Convert package.pl to Python.#1135MisterCalvin wants to merge 1 commit intoalliedmodders:1.9-devfrom
MisterCalvin wants to merge 1 commit intoalliedmodders:1.9-devfrom
Conversation
9e19afd to
4fed7a9
Compare
Contributor
Author
|
I realized after opening this that linux-1.9 executes the same |
Member
|
I think your first assessment was probably correct. I can take a closer look at this later today or tomorrow. For what it's worth, the buildbot scripts are public. (There's just no automation to automatically update them on the build master). This is the relevant piece, https://github.com/alliedmodders/build-configs/blob/master/masters/amxmodx/builders.py#L30-L38 |
Contributor
Author
|
Oh nice, thanks psy. Don't know how I missed that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The win32-1.9 builder completes the build but times out in the upload phase because it still runs
package.pl, which hangs while downloading the now-retired GeoLite2 archive. I believe @dvander will need to update the builder on his side to executepackage.pyinstead ofpackage.pl(just like the win32-1.10 builder does)Cherry-picked from 27f451a