refactor: simplify time step conversion#247
Open
nightcityblade wants to merge 1 commit into
Open
Conversation
Contributor
|
@nightcityblade Thank you for your contribution! Would you mind signing your commits with the developer certificate or origin? For more information about the DCO, see our contributer guidelines The automated DCO workflow shows some tips regarding back-signing your commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #243
Summary
BaseInputProfile.time_stepinstead of seconds followed by/ 60.Tests
uv run ruff check transformer_thermal_model/schemas/thermal_model/input_profile.pyuv run ruff format --check transformer_thermal_model/schemas/thermal_model/input_profile.pyuv run mypy transformer_thermal_model/schemas/thermal_model/input_profile.pyuv run pytest tests/schemas/test_thermal_model_profile_input.pyNote:
uv run pre-commit run --files transformer_thermal_model/schemas/thermal_model/input_profile.pywas attempted but timed out while installing hook environments locally.