Fix blank contenttabs labels for base-template pages - #7
Merged
Merged
Conversation
getPageInfo only populated the title fields when a page carried a Details component. Base-template pages (for example the Outlander grade pages) have no Details node, so contenttabs and other page lists rendered with empty labels. Fall back to the page's own title and navigation title when a Details override did not supply one.
Code Scanning ResultsYour application code has been verified against a selected set of rules used for AEM applications.
|
aaronmedina-dev
requested review from
AdamJHall and
shabith-thennakone-aligent
August 19, 2026 14:13
shabith-thennakone-aligent
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ComponentDetailsUtil.getPageInfoonly set the title fields (title,pageTitle,pageTitleNav) inside the branch that runs when a page has a Details component. Base-template pages have no Details node, so those fields were left blank and any list that renders page titles (contenttabs, navlists) showed empty labels.This adds a fallback in the always-run block: when a Details override did not supply a title, use the page's own title / navigation title. The existing single-argument
getPageTitle(page)/getPageNavTitle(page)helpers already resolvepageTitle -> title -> name(andnavTitle -> title -> name), so the value is never null and pages with a Details override keep their overridden title.the Outlander vehicle-nav grade strip rendered six tabs with empty labels because the grade pages (
ice-*) use the base template with no Details component. Behaviour matches classic 6.5 once the fallback is in place.