Skip to content

Fix blank contenttabs labels for base-template pages - #7

Merged
aaronmedina-dev merged 1 commit into
masterfrom
fix/contenttabs-base-template-page-title
Aug 24, 2026
Merged

Fix blank contenttabs labels for base-template pages#7
aaronmedina-dev merged 1 commit into
masterfrom
fix/contenttabs-base-template-page-title

Conversation

@aaronmedina-dev

@aaronmedina-dev aaronmedina-dev commented Aug 19, 2026

Copy link
Copy Markdown

ComponentDetailsUtil.getPageInfo only set the title fields (title, pageTitle, pageTitleNav) inside the branch that runs when a page has a Details component. Base-template pages have no Details node, so those fields were left blank and any list that renders page titles (contenttabs, navlists) showed empty labels.

This adds a fallback in the always-run block: when a Details override did not supply a title, use the page's own title / navigation title. The existing single-argument getPageTitle(page) / getPageNavTitle(page) helpers already resolve pageTitle -> title -> name (and navTitle -> title -> name), so the value is never null and pages with a Details override keep their overridden title.

the Outlander vehicle-nav grade strip rendered six tabs with empty labels because the grade pages (ice-*) use the base template with no Details component. Behaviour matches classic 6.5 once the fallback is in place.

getPageInfo only populated the title fields when a page carried a
Details component. Base-template pages (for example the Outlander
grade pages) have no Details node, so contenttabs and other page
lists rendered with empty labels. Fall back to the page's own title
and navigation title when a Details override did not supply one.
@cloud-manager-for-aem

Copy link
Copy Markdown

Code Scanning Results

Your application code has been verified against a selected set of rules used for AEM applications.

Metric Severity Value Result
Security Rating is B or better critical A 🟢 PASSED
Code Coverage is 50% or more important 9.70 🟠 FAILED
Security Rating is A important A 🟢 PASSED
Reliability Rating is C or better important D 🟠 FAILED
Maintainability Rating is A important A 🟢 PASSED
Number of Skipped Unit Tests is equal to 0 informational 7 🟡 FAILED
Number of Cloud Service Compatibility Issues is less than 1 informational 31 🟡 FAILED
Number of Open Issues is less than 1 informational 269 🟡 FAILED
Duplicated Lines (%) is 1% or less informational 4.20 🟡 FAILED

For additional details, please visit the pipeline execution page on Cloud Manager.

@crispy101 crispy101 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IN AARON I TRUST

@aaronmedina-dev
aaronmedina-dev merged commit cdae040 into master Aug 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants