[feat] integrate dynamicemb table fusion (wheel 20260407.97b80bf)#466
Open
tiankongdeguiji wants to merge 2 commits intoalibaba:masterfrom
Open
[feat] integrate dynamicemb table fusion (wheel 20260407.97b80bf)#466tiankongdeguiji wants to merge 2 commits intoalibaba:masterfrom
tiankongdeguiji wants to merge 2 commits intoalibaba:masterfrom
Conversation
Upgrades the dynamicemb wheel to the fused-storage build from NVIDIA recsys-examples PR alibaba#343 and adapts tzrec's shim layer to the new API. Multiple dynamicemb tables in the same TBE group are now backed by a single fused storage/cache/KV-counter automatically. The upstream `_get_dynamicemb_options_per_table` is now a pass-through validator, so tzrec's `_to_sharding_plan` populates `dim`, `max_capacity` (per-shard), `embedding_dtype`, and `index_type` directly. The obsolete `num_aligned_embedding_per_rank` shim and the matching monkey-patch are removed. Also exposes two new proto knobs on `DynamicEmbedding`: - `bucket_capacity` (default 128) — tune hash table load factor - `score_strategy = "NO_EVICTION"` — keep table capacity fixed once full Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
97b80bf). Multiple dynamicemb tables in the same TBE group are now backed by a single fusedDynamicEmbStorage/ cache /MultiTableKVCounterautomatically.tzrec/utils/dynamicemb_util.pyto the new API: the upstream_get_dynamicemb_options_per_tablebecame a pass-through validator, so_to_sharding_plannow populatesdim, per-shardmax_capacity,embedding_dtype, andindex_typedirectly. Remove the obsoletenum_aligned_embedding_per_rankalignment shim and the matching monkey-patch — the field no longer exists onDynamicEmbTableOptions.DynamicEmbedding:bucket_capacity(default 128) — tunes hash table load factor vs. probe cost.score_strategy = "NO_EVICTION"— keeps table capacity fixed once full, pairs withinit_capacity_per_rankfor growable tables.Test plan
python tzrec/tests/run.pyfortest_multi_tower_din_with_dynamicemb_train_eval— trains + evals a DIN model with dynamicemb features end-to-end on 2 GPUs.python -m unittest tzrec.tools.dynamicemb.create_dynamicemb_init_ckpt_test— verifies the init-ckpt workflow still produces a valid checkpoint that the trainer can consume.pre-commit run --files …— ruff, ruff-format, license header, mdformat all green.build_dynamicemb_constraintswithbucket_capacity=256andscore_strategy="NO_EVICTION"against the new wheel (yields aDynamicEmbTableOptionswith the configured values).🤖 Generated with Claude Code