Skip to content

fix(chat): stop streaming when you clear #6955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shaejaz wants to merge 5 commits into
base: master
Choose a base branch
from
+64 −0
Open

fix(chat): stop streaming when you clear #6955

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f2a226
add status check
shaejaz Apr 8, 2026
15b4a5d
add test
shaejaz Apr 8, 2026
a1d510e
update staus check
shaejaz Apr 10, 2026
b0eab47
update test
shaejaz Apr 10, 2026
1b342a2
stop streaming on clear
shaejaz Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/instantsearch.js/src/widgets/chat/chat.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ function ChatWrapper({
maximized,
onToggleMaximize: () => setMaximized(!maximized),
onClear: clearMessages,
canClear: Boolean(chatMessages?.length) && !isClearing,
canClear: Boolean(chatMessages?.length) && !isClearing && chatStatus === 'ready',
closeIconComponent: headerProps.closeIconComponent,
minimizeIconComponent: headerProps.minimizeIconComponent,
maximizeIconComponent: headerProps.maximizeIconComponent,
Expand Down
2 changes: 1 addition & 1 deletion packages/react-instantsearch/src/widgets/Chat.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ function ChatInner<
maximized,
onToggleMaximize: () => setMaximized(!maximized),
onClear: clearMessages,
canClear: Boolean(messages?.length) && !isClearing,
canClear: Boolean(messages?.length) && !isClearing && status === 'ready',
titleIconComponent: headerTitleIconComponent,
closeIconComponent: headerCloseIconComponent,
minimizeIconComponent: headerMinimizeIconComponent,
Expand Down
40 changes: 40 additions & 0 deletions tests/common/widgets/chat/options.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,46 @@ export function createOptionsTests(
);
});

test('disables clear button when chat is in progress', async () => {
const searchClient = createSearchClient();
const chat = new Chat({});

await setup({
instantSearchOptions: {
indexName: 'indexName',
searchClient,
},
widgetParams: {
javascript: createDefaultWidgetParams(chat),
react: createDefaultWidgetParams(chat),
vue: {},
},
});

await openChat(act);

await act(async () => {
chat._state.messages = [
{
id: '1',
role: 'user' as const,
parts: [{ type: 'text' as const, text: 'hello' }],
},
];
await wait(0);
});

const clearButton = document.querySelector('.ais-ChatHeader-clear');
expect(clearButton).not.toBeDisabled();

await act(async () => {
chat._state.status = 'streaming';
await wait(0);
});

expect(clearButton).toBeDisabled();
});

describe('cssClasses', () => {
test('adds custom CSS classes', async () => {
const searchClient = createSearchClient();
Expand Down
Loading