feat(react-instantsearch-core): provide facet metadata to DynamicWidgets fallback#6929
Closed
feat(react-instantsearch-core): provide facet metadata to DynamicWidgets fallback#6929
Conversation
Contributor
Author
|
better version in #6930 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change enriches
DynamicWidgetsfallback rendering with facet metadata from the current results, so fallback components can make visibility decisions without mounting additional facet connectors.What changed
DynamicWidgetsnow passes extra props tofallbackComponent:canRefine: booleanfacetValues: Record<string, number>attributeprop remains unchanged._rawResults[0].facetswhen available, with fallback toresults.facets.Why
When many dynamic facets are rendered through
fallbackComponent, apps often mountuseRefinementList()/useHierarchicalMenu()just to know whether a facet has values. This creates duplicate connector registrations and can significantly increase initial rendering cost for high facet counts.By passing facet metadata directly from
DynamicWidgets, fallback components can skip those extra connectors and stay mostly presentational.Tests
Added test coverage in:
packages/react-instantsearch-core/src/components/__tests__/DynamicWidgets.test.tsxNew test validates that
fallbackComponentreceives:attributecanRefinefacetValuesValidation run
yarn jest packages/react-instantsearch-core/src/components/__tests__/DynamicWidgets.test.tsx --runInBandyarn jest packages/react-instantsearch-core/src/connectors/__tests__/useDynamicWidgets.test.tsx --runInBandNotes
This is an incremental, backwards-compatible step toward reducing
DynamicWidgetsoverhead in high-facet scenarios, without removing or changing singular connectors.