Skip to content

test(environment): expose TransferStream and make test environments consistent#6717

Merged
shaejaz merged 9 commits intomasterfrom
feat/fixed-jsdom
Sep 25, 2025
Merged

test(environment): expose TransferStream and make test environments consistent#6717
shaejaz merged 9 commits intomasterfrom
feat/fixed-jsdom

Conversation

@shaejaz
Copy link
Copy Markdown
Contributor

@shaejaz shaejaz commented Sep 24, 2025

Summary
This PR adds a new custom jest environment where some missing APIs for the Chat widgets are added.

Changes:

  • Replaced all jsdom usage to the new custom env.
  • Removed the jsdom-global package as its functionality has been integrated into the new custom env.
  • Added a new custom node env and set that to the default jest env.

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Sep 24, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2d872ff:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

@shaejaz shaejaz marked this pull request as ready for review September 24, 2025 15:59
@shaejaz shaejaz requested a review from Haroenv September 24, 2025 15:59
Comment thread packages/instantsearch.js/src/lib/__tests__/server-composition.test.ts Outdated
@Haroenv Haroenv changed the title feat(testing): add fixed jsdom jest environment test(environment): expose TransferStream and make test environments consistent Sep 24, 2025
Copy link
Copy Markdown
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm when green.

In a followup PR we may be able to check if we could add some sort of alias to make the environment shorter to write

@shaejaz shaejaz merged commit a278742 into master Sep 25, 2025
14 checks passed
@shaejaz shaejaz deleted the feat/fixed-jsdom branch September 25, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants