Skip to content

fix(react-instantsearch): fix scroll refs handling #6713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Haroenv merged 2 commits into from
Sep 23, 2025
Merged

fix(react-instantsearch): fix scroll refs handling #6713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7389d9c
fix(react-instantsearch): fix scroll refs handling
FabienMotte Sep 23, 2025
5b13795
chore: update bundle size
FabienMotte Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundlesize.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
{
"path": "packages/react-instantsearch/dist/umd/ReactInstantSearch.min.js",
"maxSize": "81.25 kB"
"maxSize": "81.50 kB"
},
{
"path": "packages/vue-instantsearch/vue2/umd/index.js",
Expand Down
1 change: 0 additions & 1 deletion packages/react-instantsearch/src/ui/lib/useStickToBottom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,6 @@ function useRefCallback<T extends (ref: HTMLElement | null) => any>(
callback: T,
deps: DependencyList
) {
// biome-ignore lint/correctness/useExhaustiveDependencies: not needed
const result = useCallback((ref: HTMLElement | null) => {
result.current = ref;
return callback(ref);
Expand Down
12 changes: 9 additions & 3 deletions packages/react-instantsearch/src/widgets/Chat.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import type {
RecommendComponentProps,
RecordWithObjectID,
ChatToolMessage,
MutableRef,
} from 'instantsearch-ui-components';
import type { UIMessage } from 'instantsearch.js/es/lib/chat';
import type { UseChatOptions } from 'react-instantsearch-core';
Expand Down Expand Up @@ -93,7 +94,12 @@ type UserHeaderProps = Omit<ChatUiProps['headerProps'], 'onClose'>;

type UserMessagesProps = Omit<
ChatUiProps['messagesProps'],
'messages' | 'tools' | 'indexUiState' | 'setIndexUiState'
| 'messages'
| 'tools'
| 'indexUiState'
| 'setIndexUiState'
| 'scrollRef'
| 'contentRef'
>;

type UserPromptProps = Omit<
Expand Down Expand Up @@ -201,8 +207,8 @@ export function Chat<TObject extends RecordWithObjectID>({
setIndexUiState,
isClearing,
onClearTransitionEnd: handleClearTransitionEnd,
scrollRef: { current: scrollRef.current as HTMLDivElement },
contentRef: { current: contentRef.current as HTMLDivElement },
scrollRef: scrollRef as unknown as MutableRef<HTMLDivElement>,
contentRef: contentRef as unknown as MutableRef<HTMLDivElement>,
isScrollAtBottom: isAtBottom,
onScrollToBottom: scrollToBottom,
...messagesProps,
Expand Down