feat(instantsearch.js): introduce chat widget#6705
Merged
Conversation
Haroenv
reviewed
Sep 22, 2025
Haroenv
reviewed
Sep 23, 2025
Haroenv
reviewed
Sep 23, 2025
Haroenv
reviewed
Sep 23, 2025
Contributor
|
netlify seems to be failing because of storybook. Could you maybe use the umd entry point for that? |
Co-authored-by: Haroen Viaene <hello@haroen.me>
Haroenv
approved these changes
Sep 24, 2025
|
|
||
| <script> | ||
| import { connectAutocomplete } from 'instantsearch.js/es/connectors'; | ||
| import { connectAutocomplete } from 'instantsearch.js/es/connectors/index.umd'; |
Contributor
There was a problem hiding this comment.
hmm, pretty annoying this is needed, but no way around for now as we still want regular esm users to have access to chat
Member
There was a problem hiding this comment.
Yes, UMD has no relation with this but it technically is helpful. Wondering if we should have a barrel file "index.noAi.ts" or something, don't know if it's better 🤷. In any case we have tests to ensure both barrel files have the same connectors / widgets, so I'm not afraid of drift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the chat widget for JS and scaffolds CTS.
FX-3528