feat(autocomplete): draft React component#6702
Merged
aymeric-giraudet merged 2 commits intomasterfrom Sep 10, 2025
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1123c18:
|
aymeric-giraudet
requested review from
a team,
dhayab and
shaejaz
and removed request for
a team
Haroenv
reviewed
Sep 9, 2025
Haroenv
approved these changes
Sep 10, 2025
shaejaz
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FX-3499
Result
Still very much a draft, not too sure about the divide with
react-instantsearchand core, and whether indices will useuseIndexhooks or more custom stuff. I think it's good for now until we implement indices.Also conditional exports doesn't work 100% yet, we'd need to change
moduleResolution