Poly2 d region volume fix#157
Open
Rosstail wants to merge 3 commits intoalex9849:masterfrom
Open
Conversation
Emix33
reviewed
Mar 29, 2024
Contributor
Emix33
left a comment
Emix33
left a comment
There was a problem hiding this comment.
I believe this implementation essentially repeats #57 and will probably not be accepted by the author of this plugin as it also calculates the mathematical volume (with fractions of blocks) and not the minecraft volume where a block is either fully included in the region or not.
|
|
||
| @Override | ||
| public int getVolume() { | ||
| if (region.getPoints().size() > 4) { |
Contributor
There was a problem hiding this comment.
Polygonal regions can also have 4 points. The lines between them are just not all alligned to the minecraft blockgrid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little patch in order to fix volume calculations of Poly2D regions