-
Notifications
You must be signed in to change notification settings - Fork 0
feat: skip weekend digests and roll them into Monday #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,23 @@ | ||
| // utils/time.ts | ||
| export function getDigestWindow(hours: number): { start: Date; end: Date } { | ||
| const end = new Date(); | ||
| const start = new Date(end.getTime() - hours * 60 * 60 * 1000); | ||
| return { start, end }; | ||
| } | ||
|
|
||
| // Returns UTC daily window (midnight to midnight) for a given UTC date | ||
| export function getUtcDailyWindowFrom(candidateUtc: Date): { start: Date; end: Date; dateTitle: string } { | ||
| const y = candidateUtc.getUTCFullYear(); | ||
| const m = candidateUtc.getUTCMonth(); | ||
| const d = candidateUtc.getUTCDate(); | ||
| const start = new Date(Date.UTC(y, m, d, 0, 0, 0)); | ||
| const end = new Date(start.getTime() + 24 * 60 * 60 * 1000); | ||
| const dateTitle = start.toISOString().slice(0, 10); | ||
| return { start, end, dateTitle }; | ||
| // Sat + Sun: the two runs the weekend skip suppresses. Monday's window is | ||
| // extended by exactly this much so the skipped days are covered with no gap. | ||
| export const WEEKEND_EXTRA_HOURS = 48; | ||
|
|
||
| // Decides whether this run happens at all, and how far back it looks. | ||
| // The weekday is read in UTC so the decision never depends on the host's local | ||
| // timezone. "Weekend" therefore means the UTC weekend, which will not match the | ||
| // local calendar day everywhere — the digest itself is UTC-based throughout. | ||
| // `skipWeekend` gates the whole policy — false restores plain daily behaviour | ||
| // (weekend runs happen AND Monday gets no extension). | ||
| export function getRunSchedule( | ||
| now: Date, | ||
| skipWeekend: boolean | ||
| ): { skip: boolean; extraHours: number } { | ||
| if (!skipWeekend) return { skip: false, extraHours: 0 }; | ||
|
|
||
| const day = now.getUTCDay(); // 0 = Sun, 1 = Mon, 6 = Sat | ||
| if (day === 0 || day === 6) return { skip: true, extraHours: 0 }; | ||
|
|
||
| return { skip: false, extraHours: day === 1 ? WEEKEND_EXTRA_HOURS : 0 }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.