Skip to content

feat: add unkey support#323

Draft
Vicentesan wants to merge 3 commits into
alchemy-run:mainfrom
Vicentesan:vicentesan/unkey
Draft

feat: add unkey support#323
Vicentesan wants to merge 3 commits into
alchemy-run:mainfrom
Vicentesan:vicentesan/unkey

Conversation

@Vicentesan

Copy link
Copy Markdown

No description provided.

@Mkassabov Mkassabov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean this is fine? It looks like it didn't finish or it ignored instructions.

The only part it did right is arguably the easiest possible part which is mostly just calling out openapi generate script.

The nuke script is questionable but so are Claude's so this is fine.

It doesn't have tests or patches which are arguably the most important parts and the most ai heavy.


fs.writeFileSync(specPath, `${JSON.stringify(spec)}\n`);

generateFromOpenAPI({

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're only using API so we should remove the other submodule

@@ -0,0 +1,618 @@
#!/usr/bin/env bun
/**
* Unkey Nuke Script

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This nuke script doesn't look too much like other ones; though tbf we don't have too many of these, the ones we have aren't good either.

But still we probably need a stricter hueristic for what this looks like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants