-
Notifications
You must be signed in to change notification settings - Fork 720
Replace Puppeteer with FormePDF for PDF generation (fixes #630) #1086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danmolitor
wants to merge
6
commits into
al1abb:master
Choose a base branch
from
danmolitor:feat/replace-puppeteer-with-formepdf
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
69db689
Replace Puppeteer with FormePDF for PDF generation
danmolitor a297691
Remove orphaned InvoicePreview files
danmolitor 9ffe08e
Remove render/compare scripts
danmolitor b4d0d40
Use Outfit font for PDF templates via FormePDF custom font embedding
danmolitor 12fff36
Remove unused Inter font files
danmolitor ae0e60f
Fix review issues: DynamicInvoiceTemplate import, pdfTemplate value, …
danmolitor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 75 additions & 0 deletions
75
app/components/templates/invoice-pdf/InvoiceTemplate1.data.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| { | ||
| "sender": { | ||
| "name": "John Doe", | ||
| "address": "123 Main St", | ||
| "zipCode": "12345", | ||
| "city": "Anytown", | ||
| "country": "USA", | ||
| "email": "johndoe@example.com", | ||
| "phone": "123-456-7890" | ||
| }, | ||
| "receiver": { | ||
| "name": "Jane Smith", | ||
| "address": "456 Elm St", | ||
| "zipCode": "54321", | ||
| "city": "Other Town", | ||
| "country": "Canada", | ||
| "email": "jane@example.com", | ||
| "phone": "555-987-6543" | ||
| }, | ||
| "details": { | ||
| "invoiceLogo": "", | ||
| "invoiceNumber": "INV0001", | ||
| "invoiceDate": "March 24, 2026", | ||
| "dueDate": "March 24, 2026", | ||
| "currency": "USD", | ||
| "language": "English", | ||
| "items": [ | ||
| { | ||
| "name": "Product 1", | ||
| "description": "Description of product 1", | ||
| "quantity": 4, | ||
| "unitPrice": 50, | ||
| "total": 200 | ||
| }, | ||
| { | ||
| "name": "Product 2", | ||
| "description": "Description of product 2", | ||
| "quantity": 5, | ||
| "unitPrice": 50, | ||
| "total": 250 | ||
| }, | ||
| { | ||
| "name": "Product 3", | ||
| "description": "Description of product 3", | ||
| "quantity": 5, | ||
| "unitPrice": 80, | ||
| "total": 400 | ||
| } | ||
| ], | ||
| "paymentInformation": { | ||
| "bankName": "Bank Inc.", | ||
| "accountName": "John Doe", | ||
| "accountNumber": "445566998877" | ||
| }, | ||
| "taxDetails": { | ||
| "amount": 15, | ||
| "taxID": "TAX-123", | ||
| "amountType": "percentage" | ||
| }, | ||
| "discountDetails": { | ||
| "amount": 5, | ||
| "amountType": "percentage" | ||
| }, | ||
| "shippingDetails": { | ||
| "cost": 5, | ||
| "costType": "amount" | ||
| }, | ||
| "subTotal": 850, | ||
| "totalAmount": 975.06, | ||
| "totalAmountInWords": "Nine hundred seventy-five Dollar and six Cents", | ||
| "additionalNotes": "Thank you for your business", | ||
| "paymentTerms": "Net 30", | ||
| "pdfTemplate": 1 | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.