updated UI bugs for os type charts#5778
Open
harshithb3304 wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Agentic “Device Endpoints” dashboard section to better visualize endpoint and browser-extension adoption trends over time, and refines the layout/spacing of the charts and severity donut card.
Changes:
- Adds a new “Browsers” stat card and a “Browser Extensions Over Time by Browser Type” trend chart.
- Updates device-page summary building to track browser-only devices separately and compute a browser trend + sparkline.
- Adds a small layout CSS utility to vertically center the violations card content.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| apps/dashboard/web/polaris_web/web/src/apps/dashboard/pages/observe/agentic/DeviceEndpoints.jsx | Adds a browser trend chart + stat card, refactors chart card rendering, and adjusts grid sizing/alignment. |
| apps/dashboard/web/polaris_web/web/src/apps/dashboard/pages/observe/agentic/agenticPageBuilders.js | Extends summary building to include browserName, browser-only counts, and a browser trend/sparkline. |
| apps/dashboard/web/polaris_web/web/src/apps/dashboard/components/layouts/style.css | Adds .agentic-fill-center to vertically center content within a stretched card. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
662
to
666
| const deviceFirstSeen = {}; // deviceId → earliest startTs | ||
| agenticCollections.forEach((c) => { | ||
| const hostName = c.hostName || c.displayName || c.name; | ||
| const devId = extractEndpointId(hostName); | ||
| if (!devId) return; |
Comment on lines
+725
to
+740
| // Browser trend: count of newly-first-seen browser-only devices per browser per month. | ||
| const chromeItems = browserFirstSeenItems.filter((d) => d.browser === "chrome"); | ||
| const firefoxItems = browserFirstSeenItems.filter((d) => d.browser === "firefox"); | ||
| const edgeItems = browserFirstSeenItems.filter((d) => d.browser === "edge"); | ||
| const safariItems = browserFirstSeenItems.filter((d) => d.browser === "safari"); | ||
| const { data: browserTrendData } = cumulativeSeriesByMonth( | ||
| [ | ||
| { items: chromeItems, getTs }, | ||
| { items: firefoxItems, getTs }, | ||
| { items: edgeItems, getTs }, | ||
| { items: safariItems, getTs }, | ||
| ], | ||
| startTimestamp, | ||
| endTimestamp, | ||
| ); | ||
| const [chromeCounts, firefoxCounts, edgeCounts, safariCounts] = browserTrendData; |
Comment on lines
+800
to
+805
| browserTrend: { | ||
| chrome: chromeCounts, | ||
| firefox: firefoxCounts, | ||
| edge: edgeCounts, | ||
| safari: safariCounts, | ||
| }, |
Comment on lines
+71
to
+76
| const series = [ | ||
| {name:"Chrome", data:browserTrend.chrome || new Array(n).fill(0), color:"#4285F4"}, | ||
| {name:"Firefox", data:browserTrend.firefox || new Array(n).fill(0), color:"#FF7139"}, | ||
| {name:"Edge", data:browserTrend.edge || new Array(n).fill(0), color:"#0078D7"}, | ||
| {name:"Safari", data:browserTrend.safari || new Array(n).fill(0), color:"#00B4D8"}, | ||
| ]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.