Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[V4]: Migrate to EasyLocalization v4 with improved initialization, asset loading, and storage #742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
[V4]: Migrate to EasyLocalization v4 with improved initialization, asset loading, and storage #742
Changes from all commits
4ce6054bba4524a7840517d30d13cb289d1e8a7c544af688ae982c5a28de687ea585d1b5a12c3File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The supportedLocales parameter is being used in the EasyLocalization widget, but according to the migration guide, this parameter should be removed in v4.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The assertion message could be more descriptive. Consider changing it to 'Either path or supportedLocales must be provided' for better developer experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider making locale required in load() method.
While the class structure and documentation look good, making
localeoptional in theload()method seems inconsistent since implementations likeRootBundleAssetLoaderrequire it and throw an error if it's null.Consider updating the method signature to:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add error handling for JSON parsing and file loading.
The implementation should handle potential errors when loading and parsing JSON files.
Consider adding try-catch blocks:
@override Future<Map<String, dynamic>> load({Locale? locale}) async { if (locale == null) throw ArgumentError.notNull('locale'); var localePath = getLocalePath(locale); EasyLocalization.logger.debug('Load asset from $path'); - // Load the asset as a string and decode it as JSON - return json.decode(await rootBundle.loadString(localePath)); + try { + final jsonString = await rootBundle.loadString(localePath); + return json.decode(jsonString) as Map<String, dynamic>; + } on FlutterError catch (e) { + throw AssetLoadException('Failed to load $localePath: ${e.message}'); + } on FormatException catch (e) { + throw AssetLoadException('Invalid JSON in $localePath: ${e.message}'); + } }Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.